Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert change made in pr 890 to go along with core revert #894

Merged
merged 1 commit into from
Aug 23, 2023
Merged

revert change made in pr 890 to go along with core revert #894

merged 1 commit into from
Aug 23, 2023

Conversation

McKnight-42
Copy link
Contributor

resolves # reverts fix added in #890 to go along with core change dbt-labs/dbt-core#8306. revert should be paired with merge of dbt-labs/dbt-core#8478 and backported to 1.6.latest on merge
docs dbt-labs/docs.getdbt.com/#

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@McKnight-42 McKnight-42 added the Skip Changelog Skips GHA to check for changelog file label Aug 23, 2023
@McKnight-42 McKnight-42 requested a review from a team as a code owner August 23, 2023 19:53
@McKnight-42 McKnight-42 self-assigned this Aug 23, 2023
@cla-bot cla-bot bot added the cla:yes label Aug 23, 2023
@McKnight-42 McKnight-42 merged commit d7fb235 into main Aug 23, 2023
34 checks passed
@McKnight-42 McKnight-42 deleted the mcknight/revert-890 branch August 23, 2023 20:11
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Aug 23, 2023
@McKnight-42 @github-actions
revert change made in pr 890 to go along with core revert (#894)
0ce991f 
(cherry picked from commit d7fb235)
McKnight-42 added a commit that referenced this pull request Aug 23, 2023
@github-actions @McKnight-42
revert change made in pr 890 to go along with core revert (#894) (#895)
c4ebde3 
(cherry picked from commit d7fb235)

Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
This was referenced Sep 7, 2023
Merged
Merged
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Apr 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-rogers-dbt colin-rogers-dbt colin-rogers-dbt approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may nathaniel-may is a code owner automatically assigned from dbt-labs/adapters

Assignees

@McKnight-42 McKnight-42

Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@McKnight-42 @colin-rogers-dbt