Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox testing support for snowflake, redshift and bigquery #185

Closed
3 tasks done
emmyoop opened this issue Oct 18, 2024 · 0 comments
Closed
3 tasks done

Add tox testing support for snowflake, redshift and bigquery #185

emmyoop opened this issue Oct 18, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@emmyoop
Copy link
Member

emmyoop commented Oct 18, 2024

Tasks

Preview Give feedback
  1. enhancement
  2. enhancement
  3. enhancement

Describe the feature

Add support for testing the following adapters with tox.

  • dbt-snowflake
  • dbt-redshift
  • dbt-bigquery

This will entail:

  • modify profiles.yml to meet the desired var format (example in dbt-package-testing)
  • add the adapters to supported_adapters.env
  • add commands to tox.ini for the adapter tests
  • pass through the env vars to .github/workflows/ci.yml

Describe alternatives you've considered

Not adding other adapter support

Additional context

This work is related to issue #183. Postgres testing support was added in #181.

#184 is a blocker for supporting redshift.

The package will need to be released again after this testing is added before it will run in dbt CI.

Who will this benefit?

What kind of use case will this feature be useful for? Please be specific and provide examples, this will help us prioritize properly.

Optionally, part of this work might be to also remove CircleCI and go down to just using GitHub actions to run the same tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants