Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testing structure for dbt Labs testing support - postgres #181

Merged
merged 25 commits into from
Oct 18, 2024
Merged

Update testing structure for dbt Labs testing support - postgres #181

merged 25 commits into from
Oct 18, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Sep 5, 2024 •
edited by dbeatty10
Loading

Resolves #183

Description & motivation

Adds support for testing with tox for postgres.

This was branched off #177 that attempted to add full adapter support.

The adapters that were left out are in a new issue: #185

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 5, 2024
@emmyoop emmyoop force-pushed the er/setup-tox-postgres branch from aa3004b to 9d54347 Compare September 5, 2024 13:13
@emmyoop emmyoop force-pushed the er/setup-tox-postgres branch from 09d7aeb to 0253b5d Compare September 5, 2024 13:20
@emmyoop emmyoop force-pushed the er/setup-tox-postgres branch from 7be6043 to 2b2d023 Compare September 5, 2024 13:59
emmyoop
emmyoop commented Sep 26, 2024
View reviewed changes
supported_adapters.env Outdated Show resolved Hide resolved
@emmyoop emmyoop requested a review from dbeatty10 September 26, 2024 16:25
dbeatty10
dbeatty10 reviewed Sep 26, 2024
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
emmyoop and others added 3 commits September 26, 2024 14:18
@emmyoop @dbeatty10
Update .circleci/config.yml
91d104c 
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
@emmyoop
let circleCI set the schema
85f2eac
@emmyoop
fix readme instructions
e85ab69
@emmyoop
Copy link
Member Author

emmyoop commented Sep 26, 2024 •
edited
Loading

This has some database permission issues to work through. See if we can get those resolved and then document the solution.

Once those issues are resolved we may be able to add all the adapters into the tox testing.

Since we are only adding testing via tox for postgres, it is the only adapter that has been added/modified.

@emmyoop emmyoop changed the title Setup tox for postgres Update testing structure for dbt Labs testing support - postgres Oct 11, 2024
@emmyoop emmyoop requested a review from dbeatty10 October 18, 2024 13:17
dbeatty10
dbeatty10 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@emmyoop emmyoop merged commit e532bd4 into main Oct 18, 2024
3 checks passed
@emmyoop emmyoop mentioned this pull request Oct 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbeatty10 dbeatty10 dbeatty10 approved these changes

Assignees
No one assigned
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tox-based Integration Testing support for this package
2 participants
@emmyoop @dbeatty10