Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #129

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Update README.md #129

merged 1 commit into from
Jul 25, 2023

Conversation

cohms
Copy link
Contributor

@cohms cohms commented Jun 14, 2023

This is a:

  • [ x] documentation update

Description & motivation

Added example on the right syntax for using multiple arguments to generate_source in the Cloud IDE

Without this it wasn't clear how to call multiple arguments in the Cloud IDE. I've had customers try copying the macro syntax shown which doesn't work ( e.g. try 'schema_name': 'jaffle_shop',... instead of schema_name= 'jaffle_shop',...)

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

Added example on the right syntax for using multiple arguments to generate_source in the Cloud IDE
@cohms cohms requested a review from graciegoheen June 14, 2023 19:38
@cohms cohms requested a review from christineberger July 10, 2023 21:53
Copy link

@christineberger christineberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 The tests failing aren't a result of this change, but possibly something to make a ticket on?

@graciegoheen
Copy link
Contributor

Yep - let's open up a new issue to resolve CI checks, but we can go ahead and merge this

@cohms cohms merged commit 848c4b1 into main Jul 25, 2023
@gwenwindflower gwenwindflower deleted the cohms/generate_source_documentation_update branch February 28, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants