-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameters in generate_source
for case-sensitive identifiers
#168
Parameters in generate_source
for case-sensitive identifiers
#168
Conversation
awesome work @pnadolny13! this looks great. qq: i recently rewrote the README for contribution, how did that land with you? not sure if you'd already contributed to packages before, so perhaps you didn't need it/read it, but if you did, would love any feedback on any areas that might have been confusing or could be expanded. thanks! |
@gwenwindflower the docs were great! I didnt have any issues getting the tests set up and running other than that the |
ah awesome thanks @pnadolny13 -- i'll take a look at that i'm sure it's a quite old part of the coedebase that probably hasn't been updated in years, we definitely should probably update to a more recent postgres by default! |
@gwenwindflower and @pnadolny13 thanks for pushing this through! I hope I can get back to more dbt work soon and actually benefit from it! |
Hi @gwenwindflower , would you mind to release a new version with this improvement please ? I was also looking for that feature 👍 Regards, PS: thanks @jgillies ! |
generate_source
for case-sensitive identifiers
resolves #112
This builds off of and should replace #136. I didnt know how to continue working off @jgillies 's fork so I made my own. In comparison to that existing PR this adds:
This is a:
All pull requests from community contributors should target the
main
branch (default).Description & motivation
Checklist
Notes: