Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump utils to v0.5.0 #29

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Bump utils to v0.5.0 #29

merged 1 commit into from
Jul 31, 2020

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Jul 30, 2020

Description & motivation

Turns out we also had failing tests

Checklist

  • I have verified that these changes work locally
  • n/a I have updated the README.md (if applicable)
  • n/a I have added tests & descriptions to my models (and macros if applicable)

@clrcrl clrcrl requested a review from jtcohen6 July 30, 2020 21:18
@clrcrl clrcrl changed the base branch from master to main July 30, 2020 21:24
jtcohen6
jtcohen6 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! nice work repairing those tests

@clrcrl clrcrl merged commit f2d12b5 into main Jul 31, 2020
@clrcrl clrcrl deleted the bump-utils-0.5.0 branch July 31, 2020 14:15
jeremyholtzman pushed a commit that referenced this pull request Apr 10, 2023
Merge pull request #29 from fishtown-analytics/bump-utils-0.5.0
b3646ae 
Bump utils to v0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clrcrl @jtcohen6