Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to not specify a language in code blocks #32

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

calvingiles
Copy link
Contributor

Description & motivation

It seems that the https://hub.getdbt.com/ markdown parser doesn't work with the txt tags in the code blocks, breaking the rendering on that site. A better fix would be to make it support them, but this will make the docs readable for now.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)

@calvingiles calvingiles requested a review from clrcrl as a code owner September 8, 2020 03:13
@clrcrl clrcrl requested a review from drewbanin September 8, 2020 13:22
@clrcrl
Copy link
Contributor

clrcrl commented Sep 8, 2020

@drewbanin — I've assigned you as hub owner, as I'm not sure if this is the fix or not 😅

Copy link

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me! We definitely have some more work to do around code rendering in the hub site. Thanks @calvingiles !

@clrcrl clrcrl merged commit 7218ef8 into dbt-labs:master Sep 8, 2020
jeremyholtzman pushed a commit that referenced this pull request Apr 10, 2023
Update README.md to not specify a language in code blocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants