Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source description #40

Merged
merged 7 commits into from
Jul 7, 2021

Conversation

djbelknapdbs
Copy link

Description & motivation

Add the placeholder for description to sources requested in #17 and #28 .

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable) (n/a, no new models/macros)

@djbelknapdbs djbelknapdbs requested a review from clrcrl as a code owner May 20, 2021 15:45
@clrcrl clrcrl changed the base branch from main to dev/0.4.0 June 1, 2021 15:39
@clrcrl
Copy link
Contributor

clrcrl commented Jun 1, 2021

Hi @djbelknapdbs — thanks so much for this PR!

The tests are failing because of an unrelated issue (one that we fixed in #39). To get past this issue, try rebasing (or merging in) the latest changes

Once that's fixed, I think you'll also find that the existing integration tests start failing — we have logic that is not expecting these description keys

Finally, once we have passing code, I think we'd want to implement this as an argument, e.g. include_descriptions=True (with a default value of False(

So there's a fair bit to do:

  • rebase (or merge in) the latest changes
  • update the existing tests
  • change the macro to have include_descriptions as an arg

Let me know if you're up for this, or if all that feels like too much work (a totally reasonable response!)

@djbelknapdbs
Copy link
Author

Hi @clrcrl - thanks for the review. I'm just getting going on contributing and the testing part in particular. I think I got these issues squared away. I hijacked an existing test since it referred to all args, but if you'd rather it's a new test I can do that too.

Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djbelknapdbs This is great! Sorry for the delay, thanks for responding to Claire's feedback, all in all this LGTM.

@jtcohen6 jtcohen6 merged commit 6829ff7 into dbt-labs:dev/0.4.0 Jul 7, 2021
jeremyholtzman pushed a commit that referenced this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants