-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New functionality - Retrieve the description for identical column names from upstream models #61
Conversation
Thanks for this awesome enhancement, @b-per! 💪 Integration test and readme looks great. Two things for you to do:
Changlog entry
You can follow this pattern for adding to the changelog. Something like this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Could you take a look at the build in CircleCI? Looks like test_generate_model_yaml_upstream_descriptions
isn't passing.
Accidentally overlooked CircleCI failure originally
I got quite puzzled about why the test was passing locally but not in CI, before I realized that I needed to add a It should be all-good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, @b-per
👍 Everything looks good.
…es from upstream models (#61) * Update gitignore for latest version of dbt * Add macros to retrieve info from graph * Update README with new parameter for generate_model_yaml * Add integration test for the new feature * Update CHANGELOG with upstream_descriptions flag * Fix typos * Update CI steps to run the models before testing
This is a:
main
dev/
branchdev/
branchDescription & motivation
When using the macro
generate_model_yaml
it can be cumbersome to have to copy/paste the description of the columns from the upstream models, especially when many models are joined together.The new feature accessible via the flag
upstream_descriptions=True
(defaulted to False) parses the Jinja graph to retrieve existing descriptions in parent models.An example of output is the following, when the upstream model has an existing description of
description column a
:I am not too sure where I should add the entry in
CHANGELOG.md
Checklist