-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggestion to materialize base models as view or table #79
Suggestion to materialize base models as view or table #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to add this option! There's a few pieces of feedback to avoid backwards compatibility issues and make the naming clearer 🙏
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! It shouldn't provide a materialization in all cases - most files don't actually contain materialization configs and are instead just defined in the project.yml file
integration_tests/tests/test_generate_base_models_case_sensitive.sql
Outdated
Show resolved
Hide resolved
…ve.sql Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
Co-authored-by: Joel Labes <joel.labes@dbtlabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌠 🎉
…odels-as-view Suggestion to materialize base models as view or table
This is a:
main
dev/
branchdev/
branchDescription & motivation
Add
materialization
parameter togenerate_base_model
to allow users to choose whether to materialize the model as a table or a view.Since base models ought not to do much transformation and provide a lightweight layer atop source tables, it is not uncommon to materialize them as views while having the default materialization for a project be tables, since heavier transformation models ought not be computed on the fly as they would be on a view.
This change would also make it possible to generate base models materialized as views in bulk using the dbt-generator package.
Checklist