Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msgpack mixin to dbtClassMixin #125

Merged
merged 5 commits into from
May 7, 2024
Merged

Add msgpack mixin to dbtClassMixin #125

merged 5 commits into from
May 7, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented May 6, 2024

Supports dbt-core #10093.

Description

Enable using to_msgpack on objects with dbtClassMixin, and use of serialization context on __post_serialize__.

Checklist

@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label May 6, 2024
@gshank gshank requested a review from a team as a code owner May 6, 2024 20:17
@cla-bot cla-bot bot added the cla:yes label May 6, 2024
@gshank gshank closed this May 6, 2024
@gshank gshank reopened this May 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.29%. Comparing base (f0e2df6) to head (b7d45f8).

Files Patch % Lines
dbt_common/contracts/config/properties.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
+ Coverage   56.26%   56.29%   +0.03%     
==========================================
  Files          50       50              
  Lines        3082     3082              
==========================================
+ Hits         1734     1735       +1     
+ Misses       1348     1347       -1     
Flag Coverage Δ
unit 56.29% <88.88%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gshank gshank removed the Skip Changelog Skips GHA to check for changelog file label May 6, 2024
@gshank gshank added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit f89a516 May 7, 2024
19 checks passed
@gshank gshank deleted the streaming_serialization branch May 7, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants