Build Automation for Version Bump and Changelog #171
Conversation
peterallenwebb
had a problem deploying
to
PypiTest
GitHub Actions
Failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=======================================
Coverage 64.31% 64.31%
=======================================
Files 51 51
Lines 3228 3228
=======================================
Hits 2076 2076
Misses 1152 1152
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
|
||
| ## dbt-common 1.6.0 - July 16, 2024 |
There was a problem hiding this comment.
| ## dbt-common 1.6.0 - July 16, 2024 | |
| ## dbt-common 1.7.0 - July 30, 2024 |
| - Add to and to_columns to ColumnLevelConstraint and ModelLevelConstraint contracts ([#168](https://github.com/dbt-labs/dbt-common/issues/168)) | ||
|
|
||
| ## dbt-common 1.5.0 - July 2, 2024 | ||
|
|
||
| ## dbt-common 1.4.0 - June 18, 2024 |
There was a problem hiding this comment.
| - Add to and to_columns to ColumnLevelConstraint and ModelLevelConstraint contracts ([#168](https://github.com/dbt-labs/dbt-common/issues/168)) | |
| ## dbt-common 1.5.0 - July 2, 2024 | |
| ## dbt-common 1.4.0 - June 18, 2024 | |
| - Add to and to_columns to ColumnLevelConstraint and ModelLevelConstraint contracts ([#168](https://github.com/dbt-labs/dbt-common/issues/168)) | |
| ## dbt-common 1.4.0 - June 18, 2024 |
| - [@truls-p](https://github.com/truls-p) ([#6073](https://github.com/dbt-labs/dbt-common/issues/6073)) | ||
|
|
||
|
|
||
| ## dbt-common 0.1.0 - January 17, 2024 |
There was a problem hiding this comment.
| ## dbt-common 0.1.0 - January 17, 2024 |
There was a problem hiding this comment.
There should be corresponding markdown files for each version. You can see it on the 1.8 branch of core here. Without the corresponding markdown files, the next time we generate a changelog all of this will be wiped out. Changie just restitches together all the version markdowns each time you generate a new changelog.
The changes I added below should be in those files, not this file.
| description: "The release version number (i.e. 1.0.0b1)" | ||
| type: string | ||
| required: true | ||
| test_run: |
There was a problem hiding this comment.
I would combine test_run and deploy-to. If we're testing, deploy to pypi test, if we're not, deploy to pypi prod.
| target_branch: | ||
| required: true | ||
| type: string |
There was a problem hiding this comment.
Same here, with respect to main
| final_sha: | ||
| description: The new commit that includes the changelog and version bump. | ||
| value: ${{ jobs.determine-release-sha.outputs.final_sha }} |
There was a problem hiding this comment.
We'll still want this for when we're doing test runs
| shell: bash | ||
|
|
||
| env: | ||
| PYTHON_TARGET_VERSION: 3.8 |
There was a problem hiding this comment.
We use 3.11 in the other workflow, let's have this match
| - name: Build Artifacts | ||
| run: hatch build | ||
| shell: bash |
There was a problem hiding this comment.
I don't like that we built and tested in the first step, changed the code (version bump/changelog) and now we're building again and not testing.
| steps: | ||
| - name: Build Artifacts |
There was a problem hiding this comment.
Does this work? You should need to checkout the repo again (at the sha that comes out of the changelog/version bump job). Checkouts don't persist across jobs.
There was a problem hiding this comment.
Yeah. Good catch. This part has not been tested. I'll fix that and do a test release to verify.
resolves #92
Checklist
changie newto create a changelog entry