Merge pull request #1191 from brianhartsock/archive_character_columns

Ensure character columns are treated as string types.
dbt-labs · Dec 21, 2018 · 6004bdf · 6004bdf
2 parents d7610a7 + b263ba7
commit 6004bdf
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/dbt/schema.py b/dbt/schema.py
@@ -43,7 +43,7 @@ def data_type(self):
             return self.dtype
 
     def is_string(self):
-        return self.dtype.lower() in ['text', 'character varying']
+        return self.dtype.lower() in ['text', 'character varying', 'character']
 
     def is_numeric(self):
         return self.dtype.lower() in ['numeric', 'number']

diff --git a/test/unit/test_schema.py b/test/unit/test_schema.py
@@ -2,6 +2,17 @@
 
 import dbt.schema
 
+class TestStringType(unittest.TestCase):
+
+    def test__character_type(self):
+        col = dbt.schema.Column(
+            'fieldname',
+            'character',
+            char_size=10
+        )
+
+        self.assertEqual(col.data_type, 'character varying(10)')
+
 
 class TestNumericType(unittest.TestCase):