Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
Jacob Beck committed Feb 6, 2020
1 parent c860564 commit da74681
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions core/dbt/task/generate.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,8 @@
)
from dbt.exceptions import InternalException
from dbt.include.global_project import DOCS_INDEX_FILE_PATH
<<<<<<< HEAD
from dbt.logger import GLOBAL_LOGGER as logger
=======
from dbt.perf_utils import get_full_manifest
>>>>>>> 483b8745... fix --no-compile flag for docs generate
import dbt.ui.printer
import dbt.utils
import dbt.compilation
Expand Down Expand Up @@ -191,7 +188,7 @@ def _get_manifest(self) -> Manifest:
)
return self.manifest

def run(self):
def run(self) -> CatalogResults:
compile_results = None
if self.args.compile:
compile_results = CompileTask.run(self)
Expand Down Expand Up @@ -271,7 +268,7 @@ def get_catalog_results(
errors=errors,
)

def interpret_results(self, results):
def interpret_results(self, results: Optional[CatalogResults]) -> bool:
if results is None:
return False
if results.errors:
Expand Down

0 comments on commit da74681

Please sign in to comment.