Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.0-alpha regression: on-run-start|end hooks can no longer be supplied as strings #1097

Closed
drewbanin opened this issue Oct 29, 2018 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@drewbanin
Copy link
Contributor

Issue

Issue description

This worked in 0.11.x

# dbt_project.yml

on-run-start: "select 1 as id"
on-run-end: "select 2 as id"

whereas now it results in:

`Invalid arguments passed to "Project" instance: on-run-end.'select 1 as id' is not of type 'array'`

dbt should marshal the hook declarations into an array if a string is provided. This is the same behavior that's currently implemented for pre-hook and post-hook configs.

System information

The output of dbt --version:

0.12.0-a2

Steps to reproduce

# dbt_project.yml

on-run-start: "select 1 as id"
on-run-end: "select 2 as id"
$ dbt compile
@drewbanin drewbanin added the bug Something isn't working label Oct 29, 2018
@drewbanin drewbanin added this to the Guion Bluford milestone Oct 29, 2018
beckjake added a commit that referenced this issue Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant