Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grace Kelly] dbt debug checkmarks don't render correctly in Windows Powershell #1201

Closed
drewbanin opened this issue Dec 21, 2018 · 1 comment
Closed

[Grace Kelly] dbt debug checkmarks don't render correctly in Windows Powershell #1201

drewbanin opened this issue Dec 21, 2018 · 1 comment
Labels
bug Something isn't working
Milestone
Grace Kelly

Comments

@drewbanin
Copy link
Contributor

Issue

Issue description

In Windows Powershell, dbt's beautiful unicode checkmarks render out as escape sequences as shown below:

image 1

Unfortunate as I think this is, let's use OK and ERROR instead of ✓ and ✗.

System information

Windows 10 + Powershell
Python 3.7

As an aside, dbt debug is really helpful when creating issues, unicode chars or otherwise.
@drewbanin drewbanin added the bug Something isn't working label Dec 21, 2018
@drewbanin drewbanin added this to the Grace Kelly milestone Dec 21, 2018
@drewbanin drewbanin changed the title dbt debug checkmarks don't render correctly in Windows Powershell [Grace Kelly] dbt debug checkmarks don't render correctly in Windows Powershell Dec 21, 2018
drewbanin added a commit that referenced this issue Jan 2, 2019
@drewbanin
(fixes #1201) Replace unicode characters with ascii strings
f12b4fe
drewbanin added a commit that referenced this issue Jan 2, 2019
@drewbanin
(fixes #1201) Replace unicode characters with ascii strings
f90a5b1
@drewbanin
Copy link
Contributor Author

Fixed in #1206

iknox-fa pushed a commit that referenced this issue Feb 8, 2022
@drewbanin @iknox-fa
(fixes #1201) Replace unicode characters with ascii strings
ac36b09 
automatic commit by git-black, original commits:
  f90a5b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Grace Kelly
Development

No branches or pull requests
1 participant
@drewbanin