-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Column.is_integer() method #1969
Comments
I don't think renaming The |
@clrcrl are you interested in contributing a PR for this issue? It might be a little tricky with differing semantics between each of the databases that dbt supports, but the code will be pretty straightforward to implement after some fact-finding work :) |
Yeah I could do that for sure! |
Happy for @beckjake to take this one! |
Add Column.is_number/is_float (#1969)
Fixed in #2046 |
The Column class has an instance method,
is_numeric()
that returns true if the column is a fixed-precision Numeric type (eg. numeric), else False (including integer and float types).There are instances where I want to determine:
The second one is easy: let's add an
is_integer()
method.But I don't know how to name the first method, since
is_numeric()
is already reserved for numeric (i.e. decimal) columns. Can we renameis_numeric
tois_decimal
, or will that mess up too many things?The text was updated successfully, but these errors were encountered: