-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor rendering bug for clickable docs serve
output
#2027
Comments
PR created here: aaronsteers#1 |
Thanks @aaronsteers - I buy this! Can you open the PR you made against this repo? If you set the base branch to |
Happy to! I'll rebase against that branch ( |
hey @aaronsteers - are you still able to open up that PR against this repo? Would be good to get this fix merged for v0.16.0! |
@drewbanin - Yes - sorry to delay this. I'll try to get this done today against |
Closed and replaced with #2131 |
Describe the bug
When running
dbt serve
the printout of the url where the docs are served is rendering with a period ('.') immediately adjacent to the link. This is a minor issue but it prevents link detection from working correctly by terminals (VS Code in my case) which automatically detect URLs and render them as hyperlinks. In this case, the output is correctly parsed as a URL but because the URL includes a '.' at the end, it reaches a dead end (equivalent to pastinghttp://localhost:8081.
in chrome address bar).Steps To Reproduce
dbt docs serve
Expected behavior
Ideally, the printout would be rendered as:
Screenshots and log output
System information
Which database are you using dbt with?
The output of
dbt --version
:The operating system you're using:
The output of
python --version
:Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: