Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user-agent "dbt-{version}" to the BigQuery connection #2121

Closed
fhoffa opened this issue Feb 12, 2020 · 2 comments · Fixed by #2146
Closed

add user-agent "dbt-{version}" to the BigQuery connection #2121

fhoffa opened this issue Feb 12, 2020 · 2 comments · Fixed by #2146
Labels
bigquery enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@fhoffa
Copy link

fhoffa commented Feb 12, 2020

Describe the feature

Add an user-agent "dbt-{version}" to the BigQuery connection.

Who will this benefit?

Google can keep track of the most popular libraries used with BigQuery - and then use this information to prioritize features and recognize the most useful tools. This is done by populating the user-agent string with the corresponding "application name" and version information.

Reference

This is a similar issue and code:

The API definition for ClientInfo.user_agent:

The client info used to send a user-agent string along with API requests. If None, then default info will be used. Generally, you only need to set this if you’re developing your own library or partner tool.

Where the change would be applied:

@fhoffa fhoffa added enhancement New feature or request triage labels Feb 12, 2020
@drewbanin drewbanin added bigquery and removed triage labels Feb 12, 2020
@drewbanin drewbanin added this to the Barbara Gittings milestone Feb 12, 2020
@drewbanin drewbanin added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Feb 12, 2020
@drewbanin
Copy link
Contributor

Thanks @fhoffa - didn't know about that setting. It's a great idea. I just prioritized this one for our next release (v0.16.0 - Barbara Gittings) :)

@tswast
Copy link

tswast commented Feb 12, 2020

Example of the feature in use to track %%bigquery IPython magics usage: https://github.com/googleapis/python-bigquery/blob/3d77a75c86a599f7d36e68fea7979d748819e875/google/cloud/bigquery/magics.py#L491

beckjake added a commit that referenced this issue Feb 18, 2020
…r-agent

add a user agent with version to the bigquery client info (#2121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bigquery enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants