Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for source overriding #2264

Closed
beckjake opened this issue Mar 30, 2020 · 0 comments · Fixed by #2291
Closed

Tests for source overriding #2264

beckjake opened this issue Mar 30, 2020 · 0 comments · Fixed by #2291
Labels
enhancement New feature or request packages Functionality for interacting with installed packages

Comments

@beckjake
Copy link
Contributor

Describe the feature

Sources in the root package can override the sources defined in dependencies. That's good! But we don't test that this is the case, and could easily regress. That is bad, especially because we want to document this behavior and tell users they can rely on it.

Describe alternatives you've considered

No tests, probably break this in a future release, upset people.

Additional context

N/A

Who will this benefit?

Tests benefit everyone.

@beckjake beckjake added enhancement New feature or request triage labels Mar 30, 2020
@drewbanin drewbanin removed the triage label Mar 30, 2020
@drewbanin drewbanin added this to the Octavius Catto milestone Apr 1, 2020
@drewbanin drewbanin added the packages Functionality for interacting with installed packages label Apr 1, 2020
beckjake added a commit that referenced this issue Apr 16, 2020
…overrides-deps

Tests for source overriding (#2264)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packages Functionality for interacting with installed packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants