Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-19] Logging serialization: use mashumaro for consistency #4504

Closed
gshank opened this issue Dec 16, 2021 · 0 comments · Fixed by #4505
Closed

[CT-19] Logging serialization: use mashumaro for consistency #4504

gshank opened this issue Dec 16, 2021 · 0 comments · Fixed by #4505
Assignees
@gshank
Labels
jira logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Milestone
v1.1

Comments

@gshank
Copy link
Contributor

gshank commented Dec 16, 2021

The recent logging refactor used thePython dataclasses asdict method for serialization. For consistency with the rest of the codebase and for performance, switch to using mashumaro.
@gshank gshank self-assigned this Dec 16, 2021
@gshank gshank mentioned this issue Dec 16, 2021
Merged
4 tasks
gshank added a commit that referenced this issue Dec 17, 2021
@gshank
[#4504] Use mashumaro for serializing logging events
51d8491
gshank added a commit that referenced this issue Dec 17, 2021
@gshank
[#4504] Use mashumaro for logging serialization
8a44af0
gshank added a commit that referenced this issue Dec 17, 2021
@gshank
[#4504] Use mashumaro for logging serialization
de96b2f
gshank added a commit that referenced this issue Dec 17, 2021
@gshank
[#4504] Use mashumaro for logging serialization
c95a3de
gshank added a commit that referenced this issue Dec 17, 2021
@gshank
[#4504] Use mashumaro for logging serialization
83a2f95
gshank added a commit that referenced this issue Dec 17, 2021
@gshank
[#4504] Use mashumaro for logging serialization
6da0dec
gshank added a commit that referenced this issue Dec 20, 2021
@gshank
[#4504] Use mashumaro for logging serialization
118d86a
@leahwicz leahwicz added the jira label Jan 5, 2022
@github-actions github-actions bot changed the title Logging serialization: use mashumaro for consistency [CT-19] Logging serialization: use mashumaro for consistency Jan 5, 2022
gshank added a commit that referenced this issue Jan 6, 2022
@gshank
[#4504] Use mashumaro for logging serialization
927a3c6
gshank added a commit that referenced this issue Jan 7, 2022
@gshank
[#4504] Use mashumaro for logging serialization
1594977
gshank added a commit that referenced this issue Jan 7, 2022
@gshank
[#4504] Use mashumaro for logging serialization
dec3c1c
gshank added a commit that referenced this issue Jan 12, 2022
@gshank
[#4504] Use mashumaro for logging serialization
6572b66
gshank added a commit that referenced this issue Jan 12, 2022
@gshank
[#4504] Use mashumaro for logging serialization
775959f
gshank added a commit that referenced this issue Jan 21, 2022
@gshank
[#4504] Use mashumaro for logging serialization
afc4ac7
gshank added a commit that referenced this issue Jan 21, 2022
@gshank
[#4504] Use mashumaro for logging serialization
3fe8523
gshank added a commit that referenced this issue Jan 21, 2022
@gshank
[#4504] Use mashumaro for logging serialization
6468c96
gshank added a commit that referenced this issue Jan 27, 2022
@gshank
[#4504] Use mashumaro for logging serialization
53fccb3
gshank added a commit that referenced this issue Jan 27, 2022
@gshank
[#4504] Use mashumaro for serializing logging events (#4505)
efb890d
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
@gshank @iknox-fa
[#4504] Use mashumaro for serializing logging events (#4505)
f970955 
automatic commit by git-black, original commits:
  efb890d
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
@gshank @iknox-fa
[#4504] Use mashumaro for serializing logging events (#4505)
890f3e7 
automatic commit by git-black, original commits:
  3cafc9e
  efb890d
iknox-fa pushed a commit that referenced this issue Feb 8, 2022
@gshank @iknox-fa
[#4504] Use mashumaro for serializing logging events (#4505)
06ba992 
automatic commit by git-black, original commits:
  b2aea11
  efb890d
@jtcohen6 jtcohen6 added this to the v1.1 milestone Feb 11, 2022
@jtcohen6 jtcohen6 added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality logging labels Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gshank gshank

Labels
jira logging tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Milestone
v1.1
Development

Successfully merging a pull request may close this issue.

Use mashumaro for serializing logging events dbt-labs/dbt-core
3 participants
@gshank @jtcohen6 @leahwicz