Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-680] [Feature] Support for .py files when using file selectors #5289

Closed
1 task done
leoebfolsom opened this issue May 21, 2022 · 1 comment · Fixed by #5295
Closed
1 task done

[CT-680] [Feature] Support for .py files when using file selectors #5289

leoebfolsom opened this issue May 21, 2022 · 1 comment · Fixed by #5295
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes python_models
Milestone

Comments

@leoebfolsom
Copy link
Contributor

Is this your first time opening an issue?

Describe the Feature

dbt should just know that when i say: dbt run -m my_model.sql i mean: dbt run -m my_model

https://twitter.com/pedram_navid/status/1519160872588898304

but for .py files, since dbt Python models are gonna happen.

I would edit this code, as well as (I think?) this test.

Describe alternatives you've considered

Life would go on without this feature, but why should we settle for less when a first-time contributor (me) wants to build it.

Who will this benefit?

  • Pedram, apparently

  • Me, because I'll gain experience by making a small contribution to dbt-core.
  • The community, because with my newly gained experience, I'll be able to help with more, and more complex, issues over time.
  • There are times when it's easier to include the file extension in the dbt run command. For example, if you're generating the dbt run command from a script, and don't want to bother stripping the file extensions from the list of models you plan to run.

Are you interested in contributing this feature?

I'd like to create the PR, but i'll take any help / suggestions / guidance

Anything else?

@leoebfolsom leoebfolsom added enhancement New feature or request triage labels May 21, 2022
@leoebfolsom leoebfolsom changed the title [Feature] <title>Support for .py files when using file selectors [Feature] Support for .py files when using file selectors May 21, 2022
@github-actions github-actions bot changed the title [Feature] Support for .py files when using file selectors [CT-680] [Feature] <title>Support for .py files when using file selectors May 21, 2022
@leoebfolsom leoebfolsom changed the title [CT-680] [Feature] <title>Support for .py files when using file selectors [CT-680] [Feature] Support for .py files when using file selectors May 26, 2022
@jtcohen6
Copy link
Contributor

@leoebfolsom Props for being way ahead of the game :) and thanks for making sure this didn't get lost in the shuffle!

@jtcohen6 jtcohen6 added good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes and removed triage labels May 31, 2022
@jtcohen6 jtcohen6 added this to the v1.3 milestone Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! node selection Functionality and syntax for selecting DAG nodes python_models
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants