Add support for File Selectors and add file selectors to the default method selector list #5241
Conversation
…selection criteria if the given selector has a . in it but no path separators
…t will make Pedram happy
|
Hi! So this is a, uhh, emotionally fraught (?!) pull request, but I don't want to let that get in the way of, ya know, writing good software. The other way I could have implemented this feature was by removing the last few characters of the input selector if they looked like a file extension (that is, .sql) and then falling back to the FQN method. I didn't have a strong preference between what I did here and that option; I'm not super-familiar with the code I'm changing here and so I went with the new file selector impl on the principle that I should try not to muck with user input too much, but am more than happy to take this code in a different direction if there are other considerations here that I am unaware of. 🙇 |
There was a problem hiding this comment.
@jwills Thanks for submitting this so fast!!! And take me to different parts of the codebase! I think the current approach looks great!
If we take the other route you mentioned, we will run into some unintended behavior. For example, in my models dir I have,
test.sql
test/inside.sql
If I do dbt ls -s test.sql it will actually show both.
Maybe there's a path to refactor but I think what we currently get looks great!
…method selector list (dbt-labs#5241) * Add a new selector method for files and add it to the default method selection criteria if the given selector has a . in it but no path separators * Add a file: selector method to the default selector methods because it will make Pedram happy * changie stuff
resolves this small gripe: "To this day, I can’t give dbt a file name and hope it figures out what I mean, but instead I still have to remove the .sql at the end."
https://pedram.substack.com/p/we-need-to-talk-about-dbt
and thus fix #5240
Description
I'm adding a
FileSelectorMethodthat uses the name of a .sql file as the way to find model(s) to run via a selector and I added a check to thedefault_methodcode that does an automatic determination of which selector method to use that will prefer theFileselector to theFQNselector for selector values that end with the string ".sql".Checklist
changie newto create a changelog entry