Adds support for File selector matcher #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwills
approved these changes
May 13, 2022
|
will merge after #274 is merged & rebased into this branch |
10 tasks
drewbanin
force-pushed
the
feature/support-selectors-with-sql-exts
branch
from
afa808f
to
9164b1b
Compare
stu-k
approved these changes
May 17, 2022
|
@drewbanin do you think you'll be able to incorporate @stu-k's suggestions so we can include this in the |
|
@emmyoop Given how small the proposed changes are, I think it would make sense for us to take this over the finish line, to ensure it gets in for |
jtcohen6
added
the
ready_for_review
…ure/support-selectors-with-sql-exts # Conflicts: # CHANGELOG.md
emmyoop
force-pushed
the
feature/support-selectors-with-sql-exts
branch
from
39113c4
to
1f8895e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dbt-labs/dbt-core#5241
Description
This PR adds support for the
file:selector matcher. The file matcher is implicitly used if the provided selector name ends in a.sqlextension (case-insensitive).Note: One test was failing, though it was unrelated to this change... I need to look into that & update the changelog before merging
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.