Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-906] Logging works with Click #5530

Closed
Tracked by #5527
iknox-fa opened this issue Jul 25, 2022 · 2 comments
Closed
Tracked by #5527

[CT-906] Logging works with Click #5530

iknox-fa opened this issue Jul 25, 2022 · 2 comments

Comments

@iknox-fa
Copy link
Contributor

iknox-fa commented Jul 25, 2022 •
edited
Loading

User Story:
As a user of dbt, I want logging to work as it does currently.

Acceptance Criteria:

  • Both the legacy and the new loggers are enabled in the root click group and propagate down to all click commands.

TODO: Consider only migrating the new logger? Depends on timing of RPC replacement.
@github-actions github-actions bot changed the title Logging works with Click [CT-906] Logging works with Click Jul 25, 2022
@iknox-fa iknox-fa mentioned this issue Aug 2, 2022
Closed
29 tasks
@jtcohen6 jtcohen6 added the Refinement Maintainer input needed label Aug 10, 2022
@jtcohen6
Copy link
Contributor

TODO: Consider only migrating the new logger? Depends on timing of RPC replacement.

We think we have a path to migrate from the legacy to new logger, and it's definitely part of the plan for RPC replacement. Any work we do in dbt-core to remove the legacy logger would need to stick in our feature branch, until we're ready for the migration.

@jtcohen6 jtcohen6 removed the Refinement Maintainer input needed label Sep 16, 2022
@iknox-fa iknox-fa mentioned this issue Oct 17, 2022
Merged
6 tasks
@jtcohen6
Copy link
Contributor

jtcohen6 commented Nov 1, 2022

Resolved by #6088

@jtcohen6 jtcohen6 closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtcohen6 @iknox-fa