Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-2228] Python 3.7 End of Life: June 2023 #7082

Closed
jtcohen6 opened this issue Feb 28, 2023 · 1 comment · Fixed by #7623, dbt-labs/dbt-redshift#474 or dbt-labs/dbt-bigquery#742
Closed

[CT-2228] Python 3.7 End of Life: June 2023 #7082

jtcohen6 opened this issue Feb 28, 2023 · 1 comment · Fixed by #7623, dbt-labs/dbt-redshift#474 or dbt-labs/dbt-bigquery#742
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins Team:Adapters Issues designated for the adapter area of the code
Milestone
v1.6

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Feb 28, 2023 •
edited
Loading

Python 3.7 will reach EOL in June 2023 (PEP 537)

Per our documented policy, we should remove support for py37 in the subsequent release of dbt-core, which will be v1.6 in July 2023.

This looks like:

  • Bumping the required minimum version in setup.py, here and here
  • Removing "3.7" from the classifiers here
  • Removing "3.7" from our automated test matrix

And doing the same for each of our adapter plugins.
@jtcohen6 jtcohen6 added repo ci/cd Testing and continuous integration for dbt-core + adapter plugins internal_tooling labels Feb 28, 2023
@jtcohen6 jtcohen6 added this to the v1.6 milestone Feb 28, 2023
@github-actions github-actions bot changed the title Python 3.7 End of Life: June 2023 [CT-2228] Python 3.7 End of Life: June 2023 Feb 28, 2023
@jtcohen6 jtcohen6 added the Team:Adapters Issues designated for the adapter area of the code label Mar 3, 2023
@jtcohen6
Copy link
Contributor Author

We can also remove the conditional requirement on networkx, which handled a bug specific to Python <3.8 (#5254):

dbt-core/core/setup.py

Line 58 in a88f640

"networkx>=2.3,<2.8.1;python_version<'3.8'",

This was referenced May 15, 2023
Closed
Merged
Merged
dbeatty10 added a commit to dbt-labs/docs.getdbt.com that referenced this issue May 16, 2023
@sdebruyn @dbeatty10 @mirnawong1
update Python minimum version to 3.8 (#3369)
57cbdb1 
## What are you changing in this pull request and why?
Docs change for PR dbt-labs/dbt-core#7623 /
issue dbt-labs/dbt-core#7082

resolves #3368

## Checklist
- [x] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)
- [ ] Add a note to the prerelease version [Migration
Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/guides/migration/versions)
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [x] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

---------

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: mirnawong1 <89008547+mirnawong1@users.noreply.github.com>
This was referenced May 30, 2023
Merged
Closed
@mikealfare mikealfare mentioned this issue May 30, 2023
Merged
6 tasks
@McKnight-42 McKnight-42 mentioned this issue May 30, 2023
Closed
3 tasks
@mikealfare mikealfare mentioned this issue May 30, 2023
Merged
6 tasks
@nszoni nszoni mentioned this issue Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
repo ci/cd Testing and continuous integration for dbt-core + adapter plugins Team:Adapters Issues designated for the adapter area of the code
Projects
None yet
Milestone
v1.6
1 participant
@jtcohen6