You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Similarly, Incremental models would need to enforce contracts as part of the existing model contract validation that occurs in adapter-dispatched create_table_as macro calls in incremental materializations.
Acceptance criteria:
Introduce new adapter Integration tests that validate model contract is enforced and constraint DDL is generated for models with incremental materializations with contract: true. Ensure adapter tests pass in spark, redshift, snowflake, and bigquery repos.
Remove any existing detection / error messaging around limitations of using contract:true with certain SQL materializations. For example, here and here
Validate that and raise an error during parsing to ensure that materialized models with contract:true use the on_schema_change: append_new_columns option. (perhaps in the post_init method on the NodeConfig class here.
github-actionsbot
changed the title
Enforce model contracts for incremental materializations
[CT-2293] Enforce model contracts for incremental materializations
Mar 10, 2023
When
contract
is true, model contracts are enforced prior to table creation for table materializations.Similarly, Incremental models would need to enforce contracts as part of the existing model contract validation that occurs in adapter-dispatched
create_table_as
macro calls in incremental materializations.Acceptance criteria:
contract: true
. Ensure adapter tests pass in spark, redshift, snowflake, and bigquery repos.contract:true
with certain SQL materializations. For example, here and hereon_schema_change: append_new_columns
option. (perhaps in the post_init method on the NodeConfig class here.Related discussion / spiking: #6755
The text was updated successfully, but these errors were encountered: