add tests for enforcing contracts for incremental materializations #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
force-pushed
the
er/ct-2293-incremental-mat
branch
from
7cfa16b
to
3d56ac3
Compare
emmyoop
commented
Mar 22, 2023
emmyoop
requested review from
colin-rogers-dbt and
mikealfare
and removed request for
colin-rogers-dbt
MichelleArk
approved these changes
Mar 22, 2023
mikealfare
approved these changes
Mar 28, 2023
|
There's an error in a logging event: [AdapterEventDebug]: Unable to parse dict {'name': 'Spark', 'base_msg': 'Getting table schema for relation {}', 'args': [], 'node_info': {}} because that "SparkRelation" argument can't be parsed. |
|
Looks like this line in dbt/adapters/spark/impl.py: logger.debug("Getting table schema for relation {}", relation) That "relation" should be stringified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#7154
Description
Modifies tests to test incremental materializations
Checklist
changie newto create a changelog entry