-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-2559] [Feature] Remove unused check_new
method
#7586
Comments
check_new
methodcheck_new
method
Hi @dbeatty10 , |
Yep you got it @shivu2002a 👍 Thanks for jumping in ❤️ During code review of your pull request, you and the reviewer can confirm/deny if it is safe to fully remove it. I think the answer is "yes", but I didn't try it out myself. One other thing to note when you open a PR -- here are things I see forgotten most often for first-time contributors:
|
@dbeatty10 Sure thing. I'll try submitting a pr. Thanks 😊 |
Is this your first time submitting a feature request?
Describe the feature
It looks like
check_new
is unused after being removed in an earlier PR. If so, then could we removecheck_new
altogether?dbt-core/core/dbt/graph/selector_methods.py
Lines 539 to 540 in 43d949c
I didn't do a
git grep "check_new"
in dbt-core or any adapters, but didn't see any usage here:https://github.com/search?q=repo%3Adbt-labs%2Fdbt-core+check_new&type=code
Describe alternatives you've considered
We can leave dead code like this without creating problems, but always nice to do some spring cleaning.
Who will this benefit?
Anyone reading or developing this portion of the code base.
Are you interested in contributing this feature?
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: