Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-postgres tests require postgres #841

Closed
beckjake opened this issue Jul 12, 2018 · 1 comment
Closed

Non-postgres tests require postgres #841

beckjake opened this issue Jul 12, 2018 · 1 comment
Assignees
@beckjake
Milestone
Grace Kelly

Comments

@beckjake
Copy link
Contributor

Because of how the integration test setUp method works, our tests currently require postgres to be accessible even when we're only testing BigQuery, Snowflake, or Redshift. This became apparent when I split up the tests to run in parallel on circleci 2.0 (so no longer just running tox to get all the tests).

We should remove that dependency, and if possible preserve the current convenience offered by setUp.
@jthandy jthandy added this to the Stephen Girard milestone Oct 25, 2018
@beckjake beckjake mentioned this issue Nov 2, 2018
Merged
@beckjake beckjake self-assigned this Nov 2, 2018
@drewbanin drewbanin modified the milestones: Stephen Girard, Grace Kelly Nov 2, 2018
beckjake added a commit that referenced this issue Nov 13, 2018
@beckjake
Merge pull request #1107 from fishtown-analytics/no-postgres-for-non-…
717d1ed 
…postgres

On non-postgres tests, don't require the postgres container (#841)
@drewbanin
Copy link
Contributor

Closed by #1107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beckjake beckjake

Labels
None yet
Projects
None yet
Milestone
Grace Kelly
Development

No branches or pull requests
3 participants
@beckjake @drewbanin @jthandy