Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsing error easier to understand #9715

Closed
1 task done
martynydbt opened this issue Feb 29, 2024 · 2 comments · Fixed by #10015
Closed
1 task done

Make parsing error easier to understand #9715

martynydbt opened this issue Feb 29, 2024 · 2 comments · Fixed by #10015
Assignees
Labels
Impact: Exp pre-release Bug not yet in a stable release user docs [docs.getdbt.com] Needs better documentation
Milestone

Comments

@martynydbt
Copy link

martynydbt commented Feb 29, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

Context:

Someone set severity to warning which is not a valid severity (only warn and error are valid):

image From Gerda: This comes from jsonschema validation which often leads to somewhat strange and cryptic errors

Origin:

Coming from here

Acceptance criteria

The error is easy to understand.
"Severity can only be set to Warn or Error"

Suggested Tests

validate that the parsing error raises as expected

Impact to Other Teams

IDE surfaced, impact label is added.

Will backports be required?

No

Context

No response

@martynydbt martynydbt added user docs [docs.getdbt.com] Needs better documentation Impact: Exp pre-release Bug not yet in a stable release labels Feb 29, 2024
@martynydbt martynydbt added this to the v1.8 milestone Mar 1, 2024
@martynydbt martynydbt assigned emmyoop and aranke and unassigned emmyoop Apr 6, 2024
@FishtownBuildBot
Copy link
Collaborator

Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#5330

@runleonarun
Copy link

@martynydbt I closed the docs issue because this is already documented here: https://docs.getdbt.com/reference/resource-configs/severity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impact: Exp pre-release Bug not yet in a stable release user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants