Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop table statements quote identifiers even though quoting setting is false #983

Closed
clausherther opened this issue Sep 7, 2018 · 1 comment
Closed

Drop table statements quote identifiers even though quoting setting is false #983

clausherther opened this issue Sep 7, 2018 · 1 comment
Assignees
@beckjake
Labels
bug Something isn't working snowflake
Milestone
0.11.1 - Lucretia...

Comments

@clausherther
Copy link
Contributor

Looks like dbt generated statements to drop tables use quoted identifiers even if the quoting settings are set to false in dbt_project.yml.

Example:

quoting:
  identifier: false
  schema: false

From log:

drop table if exists "DW"."F_FREIGHT_COST" cascade
@drewbanin drewbanin added this to the 0.11.1 - Lucretia Mott milestone Sep 7, 2018
@drewbanin drewbanin added snowflake bug Something isn't working labels Sep 7, 2018
@beckjake beckjake self-assigned this Sep 7, 2018
@beckjake beckjake mentioned this issue Sep 11, 2018
Merged
beckjake added a commit that referenced this issue Sep 13, 2018
@beckjake
Merge pull request #991 from fishtown-analytics/fix/drop-table-quoting
16fa082 
Fix table/schema quoting on drop, truncate, and rename (#983)
@beckjake
Copy link
Contributor

Fixed in #991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beckjake beckjake

Labels
bug Something isn't working snowflake
Projects
None yet
Milestone
0.11.1 - Lucretia Mott
Development

No branches or pull requests
3 participants
@beckjake @drewbanin @clausherther