Include datasets with underscores when listing BigQuery datasets #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Sep 18, 2018
| @@ -250,14 +250,6 @@ def call_already_exists(schema, table): | |||
| "already_exists": call_already_exists, | |||
| } | |||
|
|
|||
| @classmethod | |||
There was a problem hiding this comment.
Was this change germane to the bq underscore fix? Or was it just dead code? Looks like it never gets called
There was a problem hiding this comment.
I found this dead code when I was trying to track down who called get_existing_schemas and what cared about what aspects, so I removed it as part of this rather than spend any mental energy on upkeep.
|
can we also change the base of this PR to dev/guion-bluford? |
beckjake
force-pushed
the
fix/bigquery-underscores
branch
2 times, most recently
from
1a804ea
to
2416a70
Compare
Co-authored-by: kf Fellows <k@therinefello.ws>
beckjake
force-pushed
the
fix/bigquery-underscores
branch
from
2416a70
to
c11cd92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #954, with regression tests against the v0.10.1 state.
To get the tests to fail you actually have to remove the
try/excepthere: https://github.com/fishtown-analytics/dbt/blob/554ecb0/dbt/adapters/bigquery/impl.py#L471-L475, it was suppressed incidentally as part of #856. This fix still skips a few get/create calls, so we should keep it! Thank you @k4y3ff!