Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logging information to capture skipped ephemeral model info #10390

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jul 1, 2024

resolves #10389

Problem

Insufficient logging information to diagnose skipped ephemeral models.

Solution

Add additional log event MarkSkippedChildren when marking dependent children of a node as skipped, and add ephemeral model status to existing LogSkipBecauseError.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@gshank gshank requested a review from a team as a code owner July 1, 2024 17:13
@cla-bot cla-bot bot added the cla:yes label Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (c215697) to head (5d39939).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10390      +/-   ##
==========================================
- Coverage   88.81%   88.79%   -0.03%     
==========================================
  Files         180      180              
  Lines       22496    22509      +13     
==========================================
+ Hits        19980    19987       +7     
- Misses       2516     2522       +6     
Flag Coverage Δ
integration 86.13% <100.00%> (-0.03%) ⬇️
unit 62.15% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.15% <80.00%> (-0.01%) ⬇️
Integration Tests 86.13% <100.00%> (-0.03%) ⬇️

@gshank gshank changed the title Add addition logging information to capture skipped ephemeral model info Add additional logging information to capture skipped ephemeral model info Jul 1, 2024
@gshank gshank merged commit a309283 into main Jul 3, 2024
66 checks passed
@gshank gshank deleted the log_ephemeral_model_failure branch July 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional logging for ephemeral model skipping
2 participants