Warn error options invalid when warn or error set to none

.changes/unreleased/Fixes-20240716-171427.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: Fix error constructing warn_error_options
+time: 2024-07-16T17:14:27.837171-04:00
+custom:
+  Author: gshank
+  Issue: "10452"

core/dbt/cli/option_types.py

@@ -1,6 +1,6 @@
 from click import Choice, ParamType
 
-from dbt.config.utils import exclusive_primary_alt_value_setting, parse_cli_yaml_string
+from dbt.config.utils import normalize_warn_error_options, parse_cli_yaml_string
 from dbt.events import ALL_EVENT_NAMES
 from dbt.exceptions import OptionNotYamlDictError, ValidationError
 from dbt_common.exceptions import DbtValidationError
@@ -51,12 +51,7 @@ class WarnErrorOptionsType(YAML):
     def convert(self, value, param, ctx):
         # this function is being used by param in click
         include_exclude = super().convert(value, param, ctx)
-        exclusive_primary_alt_value_setting(
-            include_exclude, "include", "error", "warn_error_options"
-        )
-        exclusive_primary_alt_value_setting(
-            include_exclude, "exclude", "warn", "warn_error_options"
-        )
+        normalize_warn_error_options(include_exclude)
 
         return WarnErrorOptions(
             include=include_exclude.get("include", []),

core/dbt/config/project.py

@@ -10,7 +10,7 @@
 from dbt.adapters.contracts.connection import QueryComment
 from dbt.clients.yaml_helper import load_yaml_text
 from dbt.config.selectors import SelectorDict
-from dbt.config.utils import exclusive_primary_alt_value_setting
+from dbt.config.utils import normalize_warn_error_options
 from dbt.constants import (
     DBT_PROJECT_FILE_NAME,
     DEPENDENCIES_FILE_NAME,
@@ -828,13 +828,8 @@ def read_project_flags(project_dir: str, profiles_dir: str) -> ProjectFlags:
         if project_flags is not None:
             # handle collapsing `include` and `error` as well as collapsing `exclude` and `warn`
             # for warn_error_options
-            warn_error_options = project_flags.get("warn_error_options")
-            exclusive_primary_alt_value_setting(
-                warn_error_options, "include", "error", "warn_error_options"
-            )
-            exclusive_primary_alt_value_setting(
-                warn_error_options, "exclude", "warn", "warn_error_options"
-            )
+            warn_error_options = project_flags.get("warn_error_options", {})
+            normalize_warn_error_options(warn_error_options)
 
             ProjectFlags.validate(project_flags)
             return ProjectFlags.from_dict(project_flags)

core/dbt/config/utils.py

@@ -1,4 +1,4 @@
-from typing import Any, Dict, Optional
+from typing import Any, Dict
 
 from dbt.clients import yaml_helper
 from dbt.events.types import InvalidOptionYAML
@@ -24,30 +24,36 @@
         raise
 
 
-def exclusive_primary_alt_value_setting(
-    dictionary: Optional[Dict[str, Any]],
-    primary: str,
-    alt: str,
-    parent_config: Optional[str] = None,
+def normalize_warn_error_options(
+    dictionary: Dict[str, Any],
 ) -> None:
-    """Munges in place under the primary the options for the primary and alt values
+    """Fixes fields for warn_error_options from yaml format to fields
+    expected by the WarnErrorOptions class.
+    'error' => 'include', 'warn' => 'exclude'
 
-    Sometimes we allow setting something via TWO keys, but not at the same time. If both the primary
-    key and alt key have values, an error gets raised. If the alt key has values, then we update
-    the dictionary to ensure the primary key contains the values. If neither are set, nothing happens.
+    Also validates that two different forms of accepted keys are not
+    both provided.
     """
 
-    if dictionary is None:
-        return
-
-    primary_options = dictionary.get(primary)
-    alt_options = dictionary.get(alt)
+    if "include" in dictionary and "error" in dictionary:
+        raise DbtExclusivePropertyUseError(
+            "Only `error` or `include` can be specified in `warn_error_options`, not both"
+        )
 
-    if primary_options and alt_options:
-        where = f" in `{parent_config}`" if parent_config is not None else ""
+    if "warn" in dictionary and "exclude" in dictionary:
         raise DbtExclusivePropertyUseError(
-            f"Only `{alt}` or `{primary}` can be specified{where}, not both"
+            "Only `warn` or `exclude` can be specified in `warn_error_options`, not both"
         )
 
-    if alt_options:
-        dictionary[primary] = alt_options
+    convert = {
+        "error": "include",
+        "warn": "exclude",
+    }
+    for key in list(convert.keys()):
+        if key in dictionary:
+            value = dictionary.pop(key)
+            if value is None:
+                value = []
+            dictionary[convert[key]] = value
+    if "silence" in dictionary and dictionary["silence"] is None:
+        dictionary["silence"] = []

tests/functional/configs/test_warn_error_options.py

@@ -4,7 +4,8 @@
 
 from dbt.cli.main import dbtRunner, dbtRunnerResult
 from dbt.events.types import DeprecatedModel
-from dbt.tests.util import update_config_file
+from dbt.flags import get_flags
+from dbt.tests.util import run_dbt, update_config_file
 from dbt_common.events.base_types import EventLevel
 from tests.utils import EventCatcher
 
@@ -202,3 +203,29 @@ def test_cant_set_both_exclude_and_warn(
         assert not result.success
         assert result.exception is not None
         assert "Only `warn` or `exclude` can be specified" in str(result.exception)
+
+
+class TestEmptyWarnError:
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {"my_model.sql": my_model_sql, "schema.yml": schema_yml}
+
+    # This tests for a bug in creating WarnErrorOptions when warn or
+    # error are set to None (in yaml =  warn:)
+    def test_project_flags(self, project):
+        project_flags = {
+            "flags": {
+                "send_anonymous_usage_stats": False,
+                "warn_error_options": {
+                    "warn": None,
+                    "error": None,
+                    "silence": ["TestsConfigDeprecation"],
+                },
+            }
+        }
+        update_config_file(project_flags, project.project_root, "dbt_project.yml")
+        run_dbt(["run"])
+        flags = get_flags()
+        # Note: WarnErrorOptions is not a dataclass, so you won't get "silence"
+        # from to_dict or stringifying.
+        assert flags.warn_error_options.silence == ["TestsConfigDeprecation"]

tests/unit/config/test_utils.py

@@ -1,41 +1,35 @@
 import pytest
 
-from dbt.config.utils import exclusive_primary_alt_value_setting
+from dbt.config.utils import normalize_warn_error_options
 from dbt.exceptions import DbtExclusivePropertyUseError
 
 
-class TestExclusivePrimaryAltValueSetting:
-    @pytest.fixture(scope="class")
-    def primary_key(self) -> str:
-        return "key_a"
-
-    @pytest.fixture(scope="class")
-    def alt_key(self) -> str:
-        return "key_b"
-
-    @pytest.fixture(scope="class")
-    def value(self) -> str:
-        return "I LIKE CATS"
-
-    def test_primary_set(self, primary_key: str, alt_key: str, value: str):
-        test_dict = {primary_key: value}
-        exclusive_primary_alt_value_setting(test_dict, primary_key, alt_key)
-        assert test_dict.get(primary_key) == value
-        assert test_dict.get(alt_key) is None
-
-    def test_alt_set(self, primary_key: str, alt_key: str, value: str):
-        test_dict = {alt_key: value}
-        exclusive_primary_alt_value_setting(test_dict, primary_key, alt_key)
-        assert test_dict.get(primary_key) == value
-        assert test_dict.get(alt_key) == value
-
-    def test_primary_and_alt_set(self, primary_key: str, alt_key: str, value: str):
-        test_dict = {primary_key: value, alt_key: value}
+class TestNormalizeWarnErrorOptions:
+    def test_primary_set(self):
+        test_dict = {
+            "error": ["SomeWarning"],
+        }
+        normalize_warn_error_options(test_dict)
+        assert len(test_dict) == 1
+        assert test_dict["include"] == ["SomeWarning"]
+
+    def test_convert(self):
+        test_dict = {"warn": None, "silence": None, "include": ["SomeWarning"]}
+        normalize_warn_error_options(test_dict)
+        assert test_dict["exclude"] == []
+        assert test_dict["include"] == ["SomeWarning"]
+        assert test_dict["silence"] == []
+
+    def test_both_keys_set(self):
+        test_dict = {
+            "warn": ["SomeWarning"],
+            "exclude": ["SomeWarning"],
+        }
         with pytest.raises(DbtExclusivePropertyUseError):
-            exclusive_primary_alt_value_setting(test_dict, primary_key, alt_key)
+            normalize_warn_error_options(test_dict)
 
-    def test_neither_primary_nor_alt_set(self, primary_key: str, alt_key: str):
+    def test_empty_dict(self):
         test_dict = {}
-        exclusive_primary_alt_value_setting(test_dict, primary_key, alt_key)
-        assert test_dict.get(primary_key) is None
-        assert test_dict.get(alt_key) is None
+        normalize_warn_error_options(test_dict)
+        assert test_dict.get("include") is None
+        assert test_dict.get("exclude") is None