Standardize returning ResourceTypeSelector
instances in dbt list
and dbt build
#10739
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NA
Problem
There is some unnecessary code duplication as it relates to
ResourceTypeSelector
. The backstory is explained in the PR description for #10718.Solution
Standardize the duplicated code.
One wrinkle to confirm
The one thing that is technically different is this line that sets
include_empty_nodes=True
fordbt list
. Theinclude_empty_nodes=True
line was introduced in 51da375 (within #7891), presumably to resolve #7496.There is a single case where it is false here: when
test
is the only selected resource. That would be an odd carve out! So I'm assuming that it is unintentional and we can safely make the change in this PR.However, if we do want this carve out, then we should create a functional test for it, because we don't have any for it currently.
Checklist