ignore --empty in unit test ref/source calls #10764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10516
Problem
The unit test ref and source resolvers inherit from the base resolvers, meaning they were getting
--empty
limit filters applied when used with the--empty
flag. This causes tests to fail / behave unpredictably since the mocked data is no longer used to configure the unit test!Solution
overwrite
resolve_limit
in unit test ref/source resolvers directly to always returnNone
(no limit filter applied), as they are never needed in the unit testing context.Checklist