-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "state:modified vars, behind "state_modified_compare_vars" behaviour flag" (#10793) #10813
Conversation
…aviour flag" (#10793)
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10813 +/- ##
==========================================
- Coverage 89.22% 89.12% -0.10%
==========================================
Files 183 183
Lines 23457 23402 -55
==========================================
- Hits 20930 20858 -72
- Misses 2527 2544 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ifest
Originally this work was done as part of #49. However as they are additive fields that have a default values, they aren't breaking changes. Thus here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Note this also _drops_ the `vars` field from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us to drop it.
Originally this work was done as part of #49. However as they are additive fields that have a default values, they aren't breaking changes. Thus here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Note this also _drops_ the `vars` field from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us to drop it.
Originally this work was done as part of #49. However as they are additive fields that have a default values, they aren't breaking changes. Thus here we're adding them to the v12 manifest. This is in support of the currently open dbt-core PR dbt-labs/dbt-core#10532. Note this also _drops_ the `vars` field from a few objects. It was originally added to support changes in core (dbt-labs/dbt-core#10793). However, those changes were reverted in core (dbt-labs/dbt-core#10813). Since `vars` as a field never went out in a GA release of dbt-core, it is safe for us to drop it.
Resolves #
Problem
Solution
Checklist