Fix error skip criteria (#1093)

[beckjake]

Fixes #1093

On nodes skipped due to failures, only log ERROR SKIP when the skip cause node was ephemeral.

[drewbanin]

@beckjake this behavior looks great! Can we update the error message a little? Right now it shows:

$ dbt run --model broken+
Found 10 models, 1 tests, 0 archives, 0 analyses, 96 macros, 4 operations, 1 seed files

13:37:29 | Concurrency: 8 threads (target='dev')
13:37:29 |
13:37:29 | 1 of 1 SKIP relation demo_schema.jerco due to ephemeral model error.. [ERROR SKIP]
Compilation Error in model broken (models/broken.sql)
  'reg' is undefined
13:37:29 |
13:37:29 | Finished running 1 view models in 0.28s.

Completed with 1 errors:

Compilation Error in referenced ephemeral model demo_schema.broken

I think it would be great if the last line could read:

Compilation Error in <model.package.name>, caused by compilation error in referenced ephemeral model <model.package.name>

Where the first <model.package.name> is the model that ref's the ephemeral model, and the second <model.package.name> is the ephemeral model itself.

The current output of Compilation Error in referenced ephemeral model demo_schema.broken is a little confusing because it 1) does not show you the model that failed to run and 2) it presents the ephemeral model as project.model, which looks like schema.table, which is not a thing for ephemeral models. Happy to discuss!

[beckjake]

@drewbanin resolved, I think:

$ dbt run --models broken+
Found 6 models, 0 tests, 0 archives, 0 analyses, 94 macros, 2 operations, 1 seed files

12:02:37 | Concurrency: 2 threads (target='default')
12:02:37 |
12:02:37 | 1 of 1 SKIP relation dbt_postgres.jerco due to ephemeral model error. [ERROR SKIP]
Compilation Error in model broken (models/broken.sql)
  'reg' is undefined
12:02:37 |
12:02:37 | Finished running 1 view models in 0.24s.

Completed with 1 errors:

Compilation Error in model.talk.broken, caused by compilation error in referenced ephemeral model model.talk.jerco

Done. PASS=0 ERROR=1 SKIP=0 TOTAL=1

[beckjake]

And with non-ephemerals:

Found 6 models, 0 tests, 0 archives, 0 analyses, 94 macros, 2 operations, 1 seed files

12:04:42 | Concurrency: 2 threads (target='default')
12:04:42 |
12:04:42 | 1 of 2 START view model dbt_postgres.broken2......................... [RUN]
12:04:42 | 1 of 2 ERROR creating view model dbt_postgres.broken2................ [ERROR in 0.04s]
12:04:42 | 2 of 2 SKIP relation dbt_postgres.jerco2............................. [SKIP]
12:04:42 |
12:04:42 | Finished running 2 view models in 0.24s.

Completed with 1 errors:

Database Error in model broken2 (models/broken2.sql)
  syntax error at or near "1"
  LINE 2:     select 1 1 1
                       ^
  compiled SQL at target/compiled/talk/broken2.sql

Done. PASS=0 ERROR=1 SKIP=1 TOTAL=2

[drewbanin]

I think these model uids might be backwards!

Compilation Error in model.talk.broken, caused by compilation error in referenced ephemeral model model.talk.jerco

[drewbanin]

Nice! Tested this a bunch, and it works great. Ship it