-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #10988: Validate manifest has group_map during group_lookup init #10995
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10995 +/- ##
==========================================
- Coverage 89.12% 89.06% -0.06%
==========================================
Files 183 183
Lines 23626 23630 +4
==========================================
- Hits 21057 21047 -10
- Misses 2569 2583 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not actually checking that "group_map" exists, you're checking that "groups" exists. And "group_map" isn't actually an attribute of the Manifest, only the WritableManifest (it probably ought to be, along with parent_map and child_map, but let's do a followup for that). So you should check that "group_map" exists and if it doesn't, built it with "build_group_map".
I'm not sure I follow here, will set up some time to chat about this sync today. |
Resolves #10988
Problem
dbt build --no-write-json
was failing if there was no group map.Solution
Validate
manifest.group_map
exists and add a test for the same.Checklist