Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log warnings on missing test refs [#968] #1169

Merged
merged 3 commits into from
Dec 5, 2018

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Dec 4, 2018

Fixes #968

Log a warning at warning level when dbt detects that you are running tests on a missing model. Log a similar warning at debug level when dbt detects that you are running tests on a disabled model.

This also makes dbt know the difference between disabled and warning more explicitly while processing refs, re-using some of the mechanism from the config warning check code.

@beckjake beckjake requested a review from drewbanin December 4, 2018 18:23
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor change requested here. This works very well locally -- nice work!

dbt/exceptions.py Outdated Show resolved Hide resolved
@beckjake beckjake merged commit d80b378 into dev/grace-kelly Dec 5, 2018
@beckjake beckjake deleted the feature/log-warnings-on-missing-test-refs branch December 5, 2018 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants