Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dbt debug [#1061] #1171

Merged
merged 7 commits into from
Dec 5, 2018
Merged

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Dec 4, 2018

Fixes #1061

The output is pretty much as requested in the last comment of that PR. I added some more version/python information to the top, we could hide that behind a flag but I would like it to exist.

I didn't implement the schemas listing - that would require compiling, I think and debug doesn't currently do that (it doesn't even build a full config, really).

This has to re-parse the raw profiles to provide the requested features, and some of it is a bit convoluted to match the real config loading.

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more tiny thoughts/changes

dbt/task/debug.py Outdated Show resolved Hide resolved
dbt/task/debug.py Outdated Show resolved Hide resolved
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it when the tests pass

@beckjake beckjake merged commit 963fb84 into dev/grace-kelly Dec 5, 2018
@beckjake beckjake deleted the feature/make-debug-great branch December 5, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants