use pypi for the latest version instead of git [#1122] #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Dec 5, 2018
|
I think the error handling you just added is good, but I don't think it catches the exception that happens if there's no route to pypi.org. I added this to my /etc/hosts and still saw a traceback: I think we'll actually need a try/catch around that |
drewbanin
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1122
Query the pypi api for latest version info instead of using github. This assumes that pypi behaves the way we think it does (using the latest non-prerelease version in the
infofield). I usedrequestssince it's in requirements.txt anyway and is a lot more pleasant to use for things like this.