-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Snowflake clustering #1591
Closed
bastienboutonnet
wants to merge
17
commits into
dbt-labs:dev/0.14.1
from
bastienboutonnet:feature/snowflake_cluster_by
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
70694e3
Merge pull request #1118 from fishtown-analytics/0.12.latest
drewbanin aef7866
Update CHANGELOG.md
drewbanin e60280c
Merge branch '0.12.latest'
drewbanin aaa0127
Merge pull request #1241 from fishtown-analytics/0.12.latest
drewbanin 9e36ebd
Merge branch '0.13.latest' of github.com:fishtown-analytics/dbt
cmcarthur 4e635e3
Merge branch 'master' of git://github.com/fishtown-analytics/dbt into…
bastienboutonnet adb1df0
implement snowflake cluster by
bastienboutonnet 32540a1
add alter statement
bastienboutonnet 8fbd792
add some todos and fixmes for draft PR
bastienboutonnet 2bc59e0
add one more todo
bastienboutonnet 1cabf43
break wrapping lines to avoid being bitten by a one line commen in us…
bastienboutonnet fe0be06
bring alter statements in create table and add clustering activation
bastienboutonnet b4fbf7c
add multiple keys handling
bastienboutonnet fd58297
add cluster by and automatic clustering to impl and change tests
bastienboutonnet c5c1946
Merge branch 'dev/0.14.1' of git://github.com/fishtown-analytics/dbt …
bastienboutonnet 954fed0
remove is_incremental boolean check and remove useless witespace
bastienboutonnet ba04a87
make max line length <= 79 chars
bastienboutonnet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 27 additions & 8 deletions
35
plugins/snowflake/dbt/include/snowflake/macros/adapters.sql
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just did one last scan here - I think this won't work properly if
cluster_by_keys
is provided as a list. If that happens, then the code in this branch won't be executed. I think we should move this line outside of the if block here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh dear... good catch! I can certainly fix that! BUT I just realised to cleaned my fork so I don't actually know how to can edit this on my side. I had to fork dbt again as we were experimenting and forgot this was still pending. Do you know what would be the best way to go? I could probably fork again, or do a new PR but then we'd loose the trace of our discussion (although we could refer to it even if the PR is closed). Let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh dear indeed! I've never seen this before!
There's a cool thing you can do on GitHub - if you add
.patch
to the end of a PR url, you'll get a "patch" for the change. I think you should be able to make a clean branch off ofdev/0.14.1
, then do something like:If git says that it can't apply the patch, you can try applying the patch from the commit
9e36ebd
.Let me know how it goes!