Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log, but allow, failures during cleanup rollbacks. #1647

Merged
merged 3 commits into from
Aug 2, 2019
Merged

Log, but allow, failures during cleanup rollbacks. #1647

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a026c7
Log, but allow, failures during cleanup rollbacks.
levimalott Jul 31, 2019
3099119
Log failed rollbacks to debug logs rather than to stdout.
levimalott Jul 31, 2019
0927093
Slim down the rollback failure log to appease flake8.
levimalott Jul 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/dbt/adapters/base/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,13 @@ def commit(self):
@classmethod
def _rollback_handle(cls, connection):
"""Perform the actual rollback operation."""
connection.handle.rollback()
try:
connection.handle.rollback()
except Exception:
logger.debug(
'Failed to rollback {}'.format(connection.name),
exc_info=True
)

@classmethod
def _close_handle(cls, connection):
Expand Down