Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding config for secure snowflake views #1738

Conversation

jamesohare84
Copy link

@jamesohare84 jamesohare84 commented Sep 11, 2019

This is a new enhancement for creating secure views in snowflake as discussed in Issue #1730

I haven't yet set up testing locally but I will do it soon

@cla-bot
Copy link

cla-bot bot commented Sep 11, 2019

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @jamesohare84

@dbt-labs dbt-labs deleted a comment from cla-bot bot Sep 11, 2019
@drewbanin
Copy link
Contributor

Thanks for making this PR @jamesohare84! You're all set on the CLA - you can ignore the warnings here (@cla-bot check).

I think this implementation is great, and normally, I'd just go ahead and merge this PR after kicking off the test suite. In #1739, we also have a PR from @SolariPicasso which implements the same functionality. I think you both did a great job, and I wish I could merge both of your PRs :)

In this case, I think we should roll with #1739 as @SolariPicasso was the creator of the issue. @jamesohare84 : I will very gladly give you credit for this contribution in the release notes though if you're interested! Are there any other PRs you're interesting in making to dbt? If so: I'd be more than happy to talk through them!

Thanks again for submitting this PR :)

@cla-bot cla-bot bot added the cla:yes label Sep 11, 2019
@cla-bot
Copy link

cla-bot bot commented Sep 11, 2019

The cla-bot has been summoned, and re-checked this pull request!

@jamesohare84
Copy link
Author

thanks @drewbanin - happy to be listed as a contributor

we are going to be contributing more as a team in the future so will speak to you then 👍

@drewbanin
Copy link
Contributor

Implemented in #1743 - closing this one. Thanks @jamesohare84!

@drewbanin drewbanin closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants