Add filter field to source table definitions (#1495) #1776
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1495
Added a
filter
parameter to source table definitions. It defaults toNone
. If provided, awhere {{ filter }}
clause is added to the source freshness calculation select statement.I also added some tests, did some mypy-related cleanup. While writing the tests, I needed to define some sort of reasonable behavior for when the source freshness query returns no data - I decided that we'll treat your data as if the latest update was on January 1, year 1 at 00:00:00 UTC. Hopefully that's outside your source freshness range. We could alternatively raise an exception about there being no data, but I thought the idea of your data being considered very out of date was more coherent.