Upgrade dependencies #1814
Merged
Upgrade dependencies #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Networkx minimum version set to 2.3, dropped 1.x support - removed a backwards compatibility fix Give colorama a range of supported versions, preserving the old minimum Give sqlparse a range of supported versions, preserving the old minimum Bump werkzeug to 0.15.x, 0.16 also works so allow that - when 1.0 releases it looks like it will work as well, but wait on that - drop 0.14.x support Set an upper bound on snowflake-connector-python of 2.0.x
cmcarthur
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1697
Fixes #1577
This does not address psycopg2, which we should deal with sometime but is a lot harder than these.
I've verified that werkzeug==0.15.6 and the current git master both work ok, so we should feel good about raising the werkzeug version to
>=0.15.6,<2whenever they release 1.0... unless they make more breaking changes before release. Supporting all those versions required only a one-line change to our imports, because we don't use any of the more advanced features, but it did drop support for 0.14.x.Both colorama and sqlparse saw significant version changes but appear harmless, we don't really make use of everything they offer - I've preserved the old fixed versions as minimums accordingly and expanded their maximums.
I set a snowflake connector upper bound of
<2.1as they seem to periodically make dangerous breaking changes (though, somehow 1.x -> 2.x was fine?) and I'd prefer not to be caught by surprise again. We can revert that part if we want to leave it unbounded, I don't have very strong feelings on it.