Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corrupted task state #1855

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Fix corrupted task state #1855

merged 1 commit into from
Oct 23, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Oct 23, 2019 •
edited
Loading

Fixes #1848

  • Make builtins into a special kind of RemoteMethod instead of just task_manager methods
    • they all accept timeout and task_tags parameters, although they do not currently do anything with them
  • Factor out GC into its own class
  • Make errors into a special kind of callable instead of methods
  • Store all the types of tasks on the task manager rather than pre-created tasks themselves
    • Instantiate tasks at method call-time

@cla-bot cla-bot bot added the cla:yes label Oct 23, 2019
Make builtins just another kind of RemoteMethod
f268ee9 
Move GC into its own object
Make parsing/parse failed into special callables and return those
@beckjake beckjake changed the base branch from feature/dbt-deps-rpc to dev/louisa-may-alcott October 23, 2019 21:22
@beckjake beckjake merged commit a1d651a into dev/louisa-may-alcott Oct 23, 2019
@beckjake beckjake deleted the fix/corrupted-task-state branch October 23, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RPC server: concurrent executing tasks can corrupt task state
2 participants
@beckjake @drewbanin