Fix: pedantic pluralization #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Dec 18, 2019
|
There are some failing unit tests that appear unrelated to these changes. |
|
Those failing tests all brittle tests that involve the filesystem. I will write up an issue about them - they're sensitive to weird timing issues because they all write to the same paths. |
|
merging this for 0.15.1 - thanks @jtcohen6 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No more:
https://en.wiktionary.org/wiki/Appendix:Latin_third_declension
There is, of course, a package for this. I think we're a ways away from needing it.